cmccabe commented on code in PR #13643:
URL: https://github.com/apache/kafka/pull/13643#discussion_r1275472446
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -1168,15 +1165,15 @@ private void updateWriteOffset(long offset) {
}
}
- private void claim(int epoch) {
+ private void claim(int epoch, long newLastWriteOffset) {
try {
if (curClaimEpoch != -1) {
throw new RuntimeException("Cannot claim leadership because we
are already the " +
"active controller.");
}
curClaimEpoch = epoch;
controllerMetrics.setActive(true);
- updateWriteOffset(lastCommittedOffset);
+ updateWriteOffset(newLastWriteOffset);
Review Comment:
Well, there is not really any difference between the previous iterations of
this PR and the current one in this regard. If some other component that isn't
the controller is adding messages, our supplied `requiredBaseOffset` may be
invalid. It is only a snapshot of the offset at a point in time, after all.
Which is why we check `requiredBaseOffset` in `atomicAppend`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
