ableegoldman commented on code in PR #13846:
URL: https://github.com/apache/kafka/pull/13846#discussion_r1275629503
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -755,6 +755,18 @@ public class StreamsConfig extends AbstractConfig {
public static final String DEFAULT_CLIENT_SUPPLIER_CONFIG =
"default.client.supplier";
public static final String DEFAULT_CLIENT_SUPPLIER_DOC = "Client supplier
class that implements the
<code>org.apache.kafka.streams.KafkaClientSupplier</code> interface.";
+ public static final String RACK_AWARE_ASSSIGNMENT_STRATEGY_NONE = "NONE";
+ public static final String RACK_AWARE_ASSSIGNMENT_STRATEGY_MIN_TRAFFIC =
"MIN_TRAFFIC";
+ public static final String
RACK_AWARE_ASSSIGNMENT_STRATEGY_MIN_TRAFFIC_BALANCE_SUBTOPOLOGY =
"MIN_TRAFFIC_BALANCE_SUBTOPOLOGY";
+
+ /** {@code } rack.aware.assignment.strategy */
+ @SuppressWarnings("WeakerAccess")
+ public static final String RACK_AWARE_ASSIGNMENT_STRATEGY =
"rack.aware.assignment.strategy";
Review Comment:
```suggestion
public static final String RACK_AWARE_ASSIGNMENT_STRATEGY_CONFIG =
"rack.aware.assignment.strategy";
```
We might have missed this during the KIP discussion, I don't remember, but
the standard in StreamsConfig is to suffix the config variables with.
`_CONFIG`. We should definitely do this here/now and update the KIP and
discussion thread if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
