mumrah commented on code in PR #13643:
URL: https://github.com/apache/kafka/pull/13643#discussion_r1276255234
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -1168,15 +1165,15 @@ private void updateWriteOffset(long offset) {
}
}
- private void claim(int epoch) {
+ private void claim(int epoch, long newLastWriteOffset) {
try {
if (curClaimEpoch != -1) {
throw new RuntimeException("Cannot claim leadership because we
are already the " +
"active controller.");
}
curClaimEpoch = epoch;
controllerMetrics.setActive(true);
- updateWriteOffset(lastCommittedOffset);
+ updateWriteOffset(newLastWriteOffset);
Review Comment:
Understood, I just wanted to make sure I understood the behavior here
regarding the new RaftClient API. It sounds like it's fine for us as long as
we're single writer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
