cmccabe commented on PR #13643:
URL: https://github.com/apache/kafka/pull/13643#issuecomment-1654251894
> @cmccabe, I don't follow this comment. When the client calls
KafkaRaftClient::schedule{Atomic}Append the KafkaRaftClient compare the
provided offset with the nextOffset stored in the BatchAccumulator. If we want
this method to succeed in most cases KafkaRaftClient::logEndOffset should
return that offset, BatchAccumulator::nextOffset and not the log end offset.
There can't be anything in the accumulator when we become active, because we
are not adding things to the accumulator when we are inactive. Therefore all we
need to know is the end of the log.
After becoming active, the active controller tracks its own offset and
doesn't need to access the offset in BatchAccumulator or the end of the log
offset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
