dajac commented on code in PR #14121:
URL: https://github.com/apache/kafka/pull/14121#discussion_r1277792665
##########
examples/src/main/java/kafka/examples/Consumer.java:
##########
@@ -157,9 +157,4 @@ public void onPartitionsRevoked(Collection<TopicPartition>
partitions) {
public void onPartitionsAssigned(Collection<TopicPartition> partitions) {
Utils.printOut("Assigned partitions: %s", partitions);
}
-
- @Override
- public void onPartitionsLost(Collection<TopicPartition> partitions) {
- Utils.printOut("Lost partitions: %s", partitions);
Review Comment:
I am sorry but I don't understand why you are trying to achieve here. Your
explanation is correct and the javadoc of `onPartitionsLost` also explains
this. I don't see the need for adding an extra comment just in this method in
this example. Is your goal trying to improve the example?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
