showuon commented on code in PR #14133:
URL: https://github.com/apache/kafka/pull/14133#discussion_r1279033437
##########
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##########
@@ -127,7 +127,7 @@ public class RemoteLogManagerTest {
RemoteStorageManager remoteStorageManager =
mock(RemoteStorageManager.class);
RemoteLogMetadataManager remoteLogMetadataManager =
mock(RemoteLogMetadataManager.class);
RemoteLogManagerConfig remoteLogManagerConfig = null;
- BrokerTopicStats brokerTopicStats = new BrokerTopicStats();
+ BrokerTopicStats brokerTopicStats = new BrokerTopicStats(true);
Review Comment:
force to true since we're testing `RemoteLogManager`
##########
core/src/test/java/kafka/log/remote/RemoteLogReaderTest.java:
##########
@@ -44,7 +44,7 @@
public class RemoteLogReaderTest {
public static final String TOPIC = "test";
RemoteLogManager mockRLM = mock(RemoteLogManager.class);
- BrokerTopicStats brokerTopicStats = new BrokerTopicStats();
+ BrokerTopicStats brokerTopicStats = new BrokerTopicStats(true);
Review Comment:
force to true since we're testing `RemoteLogReader`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]