gharris1727 commented on PR #14055: URL: https://github.com/apache/kafka/pull/14055#issuecomment-1660818460
> LGTM assuming the two small remaining comments (tweaking language in Plugins::maybeReportHybridDiscoveryIssue and using lowercase values in docs for plugin.discovery.mode property) are addressed. Thanks Greg! These have been addressed. > Ah, spoke too soon--it looks like the SynchronizationTest::testSimultaneousUpwardAndDownwardDelegating test case is consistently failing now. Can we look into that before merging? The test was failing because the ServiceLoaderScanner called PluginClassLoader#loadClass on the JsonConverter during the Plugins initialization. This caused the PluginClassLoader to cache the class, preventing the test from causing an upward-delegation. I've swapped out the JsonConverter for an arbitrary non-plugin class that isn't loaded during initialization. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
