guozhangwang commented on PR #13920: URL: https://github.com/apache/kafka/pull/13920#issuecomment-1663038140
> I hadn't changed the logic, it is still a slow function. whether execute performReassignments is checked by isBalanced, but it is not effective previously and this pr just fix this. I'm a bit confused now.. my understanding is that with this line of change https://github.com/apache/kafka/pull/13920/files#diff-2814643946ccefef81f480e1280e9b3e3397f4673166ca1ac47db7e3cb6fb760L1175, when num.partitions and num.consumers are not the same, we would no longer run `isBalanced | performReassignments` once per each combo, and hence it's no longer linear to num.partitions * num.consumers. Of course it would not return immediately (that's only the case when num.partitions and num.consumers happen to be equal), but it would still be much better than the old logic, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
