mjsax commented on code in PR #14157:
URL: https://github.com/apache/kafka/pull/14157#discussion_r1285341380
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSessionWindowAggregate.java:
##########
@@ -266,20 +266,22 @@ private void fetchAndEmit(final Record<KIn, VIn> record,
// Only time ordered (indexed) session store should have
implemented
// this function, otherwise a not-supported exception would throw
- final KeyValueIterator<Windowed<KIn>, VAgg> windowToEmit = store
- .findSessions(emitRangeLowerBound, emitRangeUpperBound);
-
int emittedCount = 0;
- while (windowToEmit.hasNext()) {
- emittedCount++;
- final KeyValue<Windowed<KIn>, VAgg> kv = windowToEmit.next();
-
- tupleForwarder.maybeForward(
- record.withKey(kv.key)
- .withValue(new Change<>(kv.value, null))
- // set the timestamp as the window end timestamp
- .withTimestamp(kv.key.window().end())
- .withHeaders(record.headers()));
+
+ try (final KeyValueIterator<Windowed<KIn>, VAgg> windowToEmit =
Review Comment:
Unrelated side fix to close the iterator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
