lucasbru commented on code in PR #14001:
URL: https://github.com/apache/kafka/pull/14001#discussion_r1286049066
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/tasks/DefaultTaskExecutor.java:
##########
@@ -87,11 +88,29 @@ private void runOnce(final long nowMs) {
if (currentTask == null) {
currentTask =
taskManager.assignNextTask(DefaultTaskExecutor.this);
} else {
+ boolean progressed = false;
+
+ // First, attempt to punctuate
+ if (taskExecutionMetadata.canPunctuateTask(currentTask)) {
+ if (currentTask.maybePunctuateStreamTime()) {
+ log.trace("punctuated stream time for task {} ",
currentTask.id());
+ progressed = true;
+ }
+ if (currentTask.maybePunctuateSystemTime()) {
+ log.trace("punctuated system time for task {} ",
currentTask.id());
+ progressed = true;
+ }
+ }
Review Comment:
Not really. It should not matter but it's good to be consistent here.
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/tasks/DefaultTaskExecutor.java:
##########
@@ -87,11 +88,29 @@ private void runOnce(final long nowMs) {
if (currentTask == null) {
currentTask =
taskManager.assignNextTask(DefaultTaskExecutor.this);
} else {
+ boolean progressed = false;
+
+ // First, attempt to punctuate
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
