mimaison commented on code in PR #14096:
URL: https://github.com/apache/kafka/pull/14096#discussion_r1286870183
##########
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala:
##########
@@ -607,7 +608,8 @@ object ReassignPartitionsCommand extends Logging {
groupedByTopic.forKeyValue { (topic, assignment) =>
val (_, replicas) = assignment.head
val assignedReplicas = AdminUtils.
- assignReplicasToBrokers(brokerMetadatas, assignment.size,
replicas.size)
+ assignReplicasToBrokers(brokerMetadatas.asJavaCollection,
assignment.size, replicas.size).
Review Comment:
I'm not asking about `brokerMetadatas` but instead about the whole
expression.
Why can't we use
```
val assignedReplicas = CoreUtils.replicaToBrokerAssignmentAsScala(AdminUtils.
assignReplicasToBrokers(brokerMetadatas.asJavaCollection, assignment.size,
replicas.size))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
