mjsax commented on code in PR #14164:
URL: https://github.com/apache/kafka/pull/14164#discussion_r1287701495
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/TaskAssignorConvergenceTest.java:
##########
@@ -227,15 +350,38 @@ private void formatClientStates(final boolean
printUnassigned) {
}
}
+ @Parameter
+ public boolean enableRackAwareTaskAssignor;
+
+ private String rackAwareStrategy =
StreamsConfig.RACK_AWARE_ASSIGNMENT_STRATEGY_NONE;
+
+ @Before
+ public void setUp() {
+ if (enableRackAwareTaskAssignor) {
+ rackAwareStrategy =
StreamsConfig.RACK_AWARE_ASSIGNMENT_STRATEGY_MIN_TRAFFIC;
+ }
+ }
+
+ @Parameterized.Parameters(name = "enableRackAwareTaskAssignor={0}")
+ public static Collection<Object[]> getParamStoreType() {
+ return asList(new Object[][] {
+ {true},
+ {false}
+ });
+ }
+
@Test
public void staticAssignmentShouldConvergeWithTheFirstAssignment() {
final AssignmentConfigs configs = new AssignmentConfigs(100L,
2,
0,
60_000L,
-
EMPTY_RACK_AWARE_ASSIGNMENT_TAGS);
+
EMPTY_RACK_AWARE_ASSIGNMENT_TAGS,
+ null,
+ null,
Review Comment:
fix indention
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/TaskAssignorConvergenceTest.java:
##########
@@ -248,21 +394,29 @@ public void assignmentShouldConvergeAfterAddingNode() {
final int numStatefulTasks = 11;
final int maxWarmupReplicas = 2;
final int numStandbyReplicas = 0;
+ final int numNodes = 10;
final AssignmentConfigs configs = new AssignmentConfigs(100L,
maxWarmupReplicas,
numStandbyReplicas,
60_000L,
-
EMPTY_RACK_AWARE_ASSIGNMENT_TAGS);
+
EMPTY_RACK_AWARE_ASSIGNMENT_TAGS,
+ null,
+ null,
Review Comment:
fix indention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
