cmccabe commented on code in PR #14169:
URL: https://github.com/apache/kafka/pull/14169#discussion_r1288848313
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -1112,35 +1102,12 @@ private void appendRaftEvent(String name, Runnable
runnable) {
if (this != metaLogListener) {
log.debug("Ignoring {} raft event from an old
registration", name);
} else {
- try {
- runnable.run();
- } finally {
- maybeCompleteAuthorizerInitialLoad();
- }
+ runnable.run();
}
});
}
}
- private void maybeCompleteAuthorizerInitialLoad() {
Review Comment:
Yes. I added a comment to the call to `completeInitialLoad`
```
if (!completedInitialLoad) {
// If we are receiving this onMetadataUpdate call, that means the
MetadataLoader has
// loaded up to the local high water mark. So we complete the
initial load, enabling
// the authorizer.
completedInitialLoad = true
authorizer.completeInitialLoad()
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
