mjsax commented on code in PR #14181:
URL: https://github.com/apache/kafka/pull/14181#discussion_r1290445751
##########
docs/streams/architecture.html:
##########
@@ -167,6 +167,14 @@ <h3 class="anchor-heading"><a
id="streams_architecture_recovery" class="anchor-l
rack of the active tasks fails. See
<code>rack.aware.assignment.tags</code>
in the <a
href="/{{version}}/documentation/streams/developer-guide/config-streams.html#rack-aware-assignment-tags"><b>Kafka
Streams Developer Guide</b></a> section.
</p>
+ <p>
+ There is also a client side config <code>client.rack</code> which can
set the rack for a Kafka Consumer. If broker side also have rack set via
<code>broker.rack</code>. Then rack aware task
+ assignment can be enabled to compute a task assignment which can
reduce cross rack traffic by try to assign tasks to clients with the same rack.
See <code>rack.aware.assignment.strategy</code> in
+ <a
href="/{{version}}/documentation/streams/developer-guide/config-streams.html#rack-aware-assignment-strategy"><b>Kafka
Streams Developer Guide</b></a>.
+ Note that <code>client.rack</code> can also be used to distribute
standby tasks on different "rack" from the active ones, which has a similar
functionality as <code>rack.aware.assignment.tags</code>.
+ Currently, <code>rack.aware.assignment.tag</code> takes precedence in
distributing standby tasks which means if both configs present,
<code>rack.aware.assignment.tag</code> will be used for distributing
+ standby tasks on different "rack" from the active ones because it can
configure more tag keys.
Review Comment:
```suggestion
standby tasks on different racks from the active ones because it can
configure more tag keys.
```
##########
docs/streams/architecture.html:
##########
@@ -167,6 +167,14 @@ <h3 class="anchor-heading"><a
id="streams_architecture_recovery" class="anchor-l
rack of the active tasks fails. See
<code>rack.aware.assignment.tags</code>
in the <a
href="/{{version}}/documentation/streams/developer-guide/config-streams.html#rack-aware-assignment-tags"><b>Kafka
Streams Developer Guide</b></a> section.
</p>
+ <p>
+ There is also a client side config <code>client.rack</code> which can
set the rack for a Kafka Consumer. If broker side also have rack set via
<code>broker.rack</code>. Then rack aware task
+ assignment can be enabled to compute a task assignment which can
reduce cross rack traffic by try to assign tasks to clients with the same rack.
See <code>rack.aware.assignment.strategy</code> in
+ <a
href="/{{version}}/documentation/streams/developer-guide/config-streams.html#rack-aware-assignment-strategy"><b>Kafka
Streams Developer Guide</b></a>.
Review Comment:
Drop this line
##########
docs/streams/architecture.html:
##########
@@ -167,6 +167,14 @@ <h3 class="anchor-heading"><a
id="streams_architecture_recovery" class="anchor-l
rack of the active tasks fails. See
<code>rack.aware.assignment.tags</code>
in the <a
href="/{{version}}/documentation/streams/developer-guide/config-streams.html#rack-aware-assignment-tags"><b>Kafka
Streams Developer Guide</b></a> section.
</p>
+ <p>
+ There is also a client side config <code>client.rack</code> which can
set the rack for a Kafka Consumer. If broker side also have rack set via
<code>broker.rack</code>. Then rack aware task
+ assignment can be enabled to compute a task assignment which can
reduce cross rack traffic by try to assign tasks to clients with the same rack.
See <code>rack.aware.assignment.strategy</code> in
Review Comment:
```suggestion
assignment can be enabled via
<code>rack.aware.assignment.strategy</code> (cf. <a
href="/{{version}}/documentation/streams/developer-guide/config-streams.html#rack-aware-assignment-strategy"><b>Kafka
Streams Developer Guide</b></a>) to compute a task assignment which can reduce
cross rack traffic by trying to assign tasks to clients with the same rack.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
