ethaden commented on code in PR #14130:
URL: https://github.com/apache/kafka/pull/14130#discussion_r1294020659


##########
clients/src/test/resources/log4j.properties:
##########
@@ -19,3 +19,5 @@ log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
 log4j.appender.stdout.layout.ConversionPattern=[%d] %p %m (%c:%L)%n
 
 log4j.logger.org.apache.kafka=ERROR
+# We are testing for a particular INFO log message in DefaultSslEngineFactory
+log4j.logger.org.apache.kafka.common.security.ssl.DefaultSslEngineFactory=INFO

Review Comment:
   This was my first idea, too. But I tried several ways to do that 
programmatically and failed. AFAIK, slf4j does not provide any means to change 
the log level as it only acts as facade for logging frameworks such as log4j. 
But, importing log4j into the test cases to update the log level under the hood 
is currently prohibited by the stylechecker (log4j is blacklisted). Thus, 
changing the properties file seemed to be the least intrusive way to handle 
that issue.
   Do you have a hint how the log level could be changed anyway?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to