clolov commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1294261443
##########
core/src/main/scala/kafka/server/ConfigHandler.scala:
##########
@@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager,
kafkaConfig: KafkaC
topicConfig.asScala.forKeyValue { (key, value) =>
if (!configNamesToExclude.contains(key)) props.put(key, value)
}
+
+ if (!kafkaConfig.remoteLogManagerConfig.enableRemoteStorageSystem()
+ && topicConfig.getProperty(TopicConfig.REMOTE_LOG_STORAGE_ENABLE_CONFIG)
!= null) {
Review Comment:
Sure, I will change to condition to only check for the value being true
rather than its presence! As mentioned, I am happy with either 😊
##########
core/src/main/scala/kafka/server/ConfigHandler.scala:
##########
@@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager,
kafkaConfig: KafkaC
topicConfig.asScala.forKeyValue { (key, value) =>
if (!configNamesToExclude.contains(key)) props.put(key, value)
}
+
+ if (!kafkaConfig.remoteLogManagerConfig.enableRemoteStorageSystem()
+ && topicConfig.getProperty(TopicConfig.REMOTE_LOG_STORAGE_ENABLE_CONFIG)
!= null) {
Review Comment:
Sure, I will change to condition to only check for the value being true
rather than its presence! As mentioned, I am happy with either 😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
