[GitHub] [kafka] lianetm commented on a diff in pull request #14218: KAFKA-14937; [2/N]: Refactoring for client code to reduce boilerplate

[via GitHub]

lianetm commented on code in PR #14218:
URL: https://github.com/apache/kafka/pull/14218#discussion_r1295036974


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerUtils.java:
##########
@@ -134,44 +132,20 @@ public static FetchMetricsManager 
createFetchMetricsManager(Metrics metrics) {
     }
 
     public static <K, V> FetchConfig<K, V> createFetchConfig(ConsumerConfig 
config,
-                                                             Deserializer<K> 
keyDeserializer,
-                                                             Deserializer<V> 
valueDeserializer) {
-        IsolationLevel isolationLevel = createIsolationLevel(config);
-        return new FetchConfig<>(config, keyDeserializer, valueDeserializer, 
isolationLevel);
+                                                             Deserializers<K, 
V> deserializers) {
+        IsolationLevel isolationLevel = getConfiguredIsolationLevel(config);
+        return new FetchConfig<>(config, deserializers, isolationLevel);
     }
 
-    @SuppressWarnings("unchecked")
-    public static <K, V> List<ConsumerInterceptor<K, V>> 
createConsumerInterceptors(ConsumerConfig config) {
-        return ClientUtils.createConfiguredInterceptors(config,
-                ConsumerConfig.INTERCEPTOR_CLASSES_CONFIG,
-                ConsumerInterceptor.class);
+    public static FetchConfig<String, String> createFetchConfig(ConsumerConfig 
config) {
+        Deserializers<String, String> deserializers = new Deserializers<>(new 
StringDeserializer(), new StringDeserializer());

Review Comment:
   You're right, I don't think it is. This was defined like this in the commit 
we are cherry-picking though, that's why it ended up here, but I'll include the 
latest changes with the fix.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org