pprovenzano commented on code in PR #14083:
URL: https://github.com/apache/kafka/pull/14083#discussion_r1296576394


##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -202,6 +211,11 @@ static public class Builder {
         private BootstrapMetadata bootstrapMetadata = null;
         private int maxRecordsPerBatch = MAX_RECORDS_PER_BATCH;
         private boolean zkMigrationEnabled = false;
+        private DelegationTokenCache tokenCache;
+        private String tokenKeyString;

Review Comment:
   The config var is delegationTokenSecretKey which is a String.
   The DelegationTokenManager calls things secretKey but sometimes that is not 
a String and instead a byte array or something else. 
   I wanted to be explicit that this is a String and that no changes are made 
to it until it is used to create a DelegationToken.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to