[GitHub] [kafka] jsancio commented on a diff in pull request #14213: KAFKA-15345; KRaft leader notifies when listener reaches epoch start

[via GitHub]

jsancio commented on code in PR #14213:
URL: https://github.com/apache/kafka/pull/14213#discussion_r1297478419


##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -2653,11 +2652,11 @@ private boolean shouldFireLeaderChange(LeaderAndEpoch 
leaderAndEpoch) {
         }
 
         private void maybeFireLeaderChange(LeaderAndEpoch leaderAndEpoch, long 
epochStartOffset) {
-            // If this node is becoming the leader, then we can fire 
`handleClaim` as soon
+            // If this node is becoming the leader, then we can fire 
`handleLeaderChange` as soon

Review Comment:
   I added a few more sentences to this comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org