clolov commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1300216608
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -500,22 +500,29 @@ public static void validateBrokerLogConfigValues(Map<?,
?> props,
* The default values should be extracted from the KafkaConfig.
* @param props The properties to be validated
*/
- private static void validateTopicLogConfigValues(Map<?, ?> props,
- boolean
isRemoteLogStorageSystemEnabled) {
+ public static void validateTopicLogConfigValues(Map<?, ?> props,
Review Comment:
I am ambivalent. If I am to use `validateRemoteStorageOnlyIfSystemEnabled` I
would still need another validation function to check for the topic-level
config, no? Otherwise the `validateRemoteStorageOnlyIfSystemEnabled` will only
operate based on knowledge of the system-wide config. Are you okay with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
