mimaison commented on code in PR #14211:
URL: https://github.com/apache/kafka/pull/14211#discussion_r1301958711
##########
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##########
@@ -541,6 +541,8 @@ private static int configureDeliveryTimeout(ProducerConfig
config, Logger log) {
int requestTimeoutMs =
config.getInt(ProducerConfig.REQUEST_TIMEOUT_MS_CONFIG);
int lingerAndRequestTimeoutMs = (int) Math.min((long) lingerMs +
requestTimeoutMs, Integer.MAX_VALUE);
+ System.out.println(deliveryTimeoutMs);
Review Comment:
Can we undo this debug statement?
##########
clients/src/test/java/org/apache/kafka/clients/admin/internals/AbortTransactionHandlerTest.java:
##########
@@ -52,6 +52,7 @@ public class AbortTransactionHandlerTest {
@Test
public void testInvalidBuildRequestCall() {
AbortTransactionHandler handler = new
AbortTransactionHandler(abortSpec, logContext);
+
Review Comment:
Can we undo this unrelated change?
##########
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java:
##########
@@ -2399,4 +2400,39 @@ public KafkaProducer<T, T> newKafkaProducer() {
}
}
+ @Test
+ void testSerializerMustNoBeANull() {
Review Comment:
Right, it's not exactly the same. If you really want to keep it, maybe we
can just add this check to the existing test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
