showuon commented on PR #14236: URL: https://github.com/apache/kafka/pull/14236#issuecomment-1690921094
Note: It's possible that the 1st time, we're building a request for version 2 AlterPartition Request, and then, after retry (ex: NOT_CONTROLLER), when sending to another node, we're trying to send with version 3 AlterPartition Request, because the new node supports version3. In this situation, it'll failed when serializing the request because we don't expect `newISR` field having value, and then, rebuild everything, so it will work eventually. That said, current change works fine for cases when retrying to send to nodes with different supported version. I'll merge this PR this week if there's no other comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
