[GitHub] [kafka] showuon commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

[via GitHub]

showuon commented on code in PR #14127:
URL: https://github.com/apache/kafka/pull/14127#discussion_r1305605102


##########
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemotePartitionMetadataStore.java:
##########
@@ -153,7 +153,7 @@ private FileBasedRemoteLogMetadataCache 
getRemoteLogMetadataCache(TopicIdPartiti
         }
 
         if (!remoteLogMetadataCache.isInitialized()) {
-            throw new ResourceNotReadyException("Remote log metadata cache is 
not initialized for partition: " + topicIdPartition);
+            throw new ReplicaNotAvailableException("Remote log metadata cache 
is not initialized for partition: " + topicIdPartition);

Review Comment:
   Could we add a comment here to explain why we throw this exception, ex:
   `Throwing a retriable ReplicaNotAvailableException here to for clients 
retry. We can introduce a new more appropriate exception with a KIP in the 
future.`  WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org