ahuang98 commented on code in PR #14295:
URL: https://github.com/apache/kafka/pull/14295#discussion_r1306085655
##########
core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala:
##########
@@ -211,16 +227,27 @@ class ProducerFailureHandlingTest extends
KafkaServerTestHarness {
assertThrows(classOf[IllegalStateException], () => producer3.send(record))
}
- @Test
- def testCannotSendToInternalTopic(): Unit = {
- TestUtils.createOffsetsTopic(zkClient, servers)
+ @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
+ @ValueSource(strings = Array("zk", "kraft"))
+ def testCannotSendToInternalTopic(quorum: String): Unit = {
+
+ admin = TestUtils.createAdminClient(brokers, listenerName,
+ TestUtils.securityConfigs(Mode.CLIENT,
+ securityProtocol,
+ trustStoreFile,
+ "adminClient",
+ TestUtils.SslCertificateCn,
+ clientSaslProperties))
+ TestUtils.createOffsetsTopicWithAdmin(admin, brokers)
+ //TestUtils.createOffsetsTopic(zkClient, brokers)
Review Comment:
there's a `createOffsetsTopic` defined in `KafkaServerTestHarness` which
takes care of creating and deleting an admin client
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
