gharris1727 commented on code in PR #14303:
URL: https://github.com/apache/kafka/pull/14303#discussion_r1307943936
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java:
##########
@@ -429,7 +429,9 @@ void enrich(ConfigDef newDef) {
final ConfigDef.Validator typeValidator =
ConfigDef.LambdaValidator.with(
(String name, Object value) -> {
validateProps(prefix);
- getConfigDefFromConfigProvidingClass(typeConfig,
(Class<?>) value);
+ if (value != null) {
Review Comment:
> It looks like the error swallowing in
ConfigDef.EnrichablePlugin::populateConfigDef takes place conditionally
Yeah, the condition depends on whether validation is being executed or
whether the full ConnectorConfig is being constructed.
> we still do throw exceptions that originate from the
getConfigDefFromConfigProvidingClass sometimes.
I think the other exceptions for non-null classes are fine to leave as-is. I
think we could only reasonably change the null-class behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
