C0urante opened a new pull request, #14309: URL: https://github.com/apache/kafka/pull/14309
[Jira 1](https://issues.apache.org/jira/browse/KAFKA-13328), [Jira 2](https://issues.apache.org/jira/browse/KAFKA-13329) Depends on https://github.com/apache/kafka/pull/14304 Although the `Converter` and `HeaderConverter` interfaces both include methods to provide a `ConfigDef` object, we don't make use of them during preflight configuration validation. This makes Kafka Connect harder to use with, among other things, programmatic UIs that perform automatic validation as soon as users enter in new key/value pairs. Additionally, it causes errors in configuration to surface at runtime (after rebalances have taken place and while tasks are being instantiated), which is less convenient for all users. This PR uses these `ConfigDef` objects for preflight validation if the user specifies a custom key, value, and/or header converter class in their connector config. If a key, value, or header converter returns a null `ConfigDef`, we simply log a warning. Although this is technically disallowed by the `Converter` and `HeaderConverter` API, because we have not been enforcing that requirement up til now, we permit that case in order to not break existing setups. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
