showuon commented on code in PR #14192:
URL: https://github.com/apache/kafka/pull/14192#discussion_r1309953193


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##########
@@ -501,7 +501,10 @@ boolean joinGroupIfNeeded(final Timer timer) {
                     final String fullReason = String.format("rebalance failed 
due to '%s' (%s)",
                         exception.getMessage(),
                         simpleName);
-                    requestRejoin(shortReason, fullReason);
+                    // Don't need to request rejoin again for 
MemberIdRequiredException since we've done that in JoinGroupResponseHandler
+                    if 
(!MemberIdRequiredException.class.getSimpleName().equals(simpleName)) {

Review Comment:
   Ah, nice suggestion!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to