jeffkbkim commented on code in PR #14122:
URL: https://github.com/apache/kafka/pull/14122#discussion_r1311901030
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##########
@@ -8179,29 +7770,30 @@ public void testGenerationIdIncrementsOnRebalance()
throws Exception {
.build();
JoinGroupResponseData leaderJoinResponse =
context.joinGenericGroupAsDynamicMemberAndCompleteRebalance("group-id");
- CompletableFuture<JoinGroupResponseData> joinFuture = new
CompletableFuture<>();
- CoordinatorResult<Void, Record> result = context.sendGenericGroupJoin(
+ JoinResult joinResult = context.sendGenericGroupJoin(
new JoinGroupRequestBuilder()
.withGroupId("group-id")
.withMemberId(leaderJoinResponse.memberId())
.withDefaultProtocolTypeAndProtocols()
- .build(),
- joinFuture);
+ .build()
+ );
- assertTrue(result.records().isEmpty());
- assertTrue(joinFuture.isDone());
- assertEquals(2, joinFuture.get().generationId());
- assertEquals(Errors.NONE.code(), joinFuture.get().errorCode());
+ assertTrue(joinResult.records.isEmpty());
+ assertTrue(joinResult.joinFuture.isDone());
+ assertEquals(2, joinResult.joinFuture.get().generationId());
+ assertEquals(Errors.NONE.code(),
joinResult.joinFuture.get().errorCode());
}
private List<JoinGroupResponseMember> toJoinResponseMembers(GenericGroup
group) {
Review Comment:
thanks. updated and moved to the bottom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
