[GitHub] [kafka] dajac commented on a diff in pull request #14321: KAFKA-14499: [6/N] Add MemberId and MemberEpoch to OffsetFetchRequest

[via GitHub]

dajac commented on code in PR #14321:
URL: https://github.com/apache/kafka/pull/14321#discussion_r1316210535


##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java:
##########
@@ -1491,10 +1526,15 @@ public void 
testConsumerGroupOffsetFetchWithUnknownMemberId() {
                 .setPartitionIndexes(Collections.singletonList(0))
         );
 
+        // Fetch offsets cases.
+        assertThrows(UnknownMemberIdException.class,
+            () -> context.fetchOffsets("group", "", 0, topics, 
Long.MAX_VALUE));

Review Comment:
   Yeah, I changed the member id to be nullable and null by default. I think 
that it makes more sense. So now, an empty string raises an unknown member id 
error.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org