[
https://issues.apache.org/jira/browse/KAFKA-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499063#comment-16499063
]
ASF GitHub Bot commented on KAFKA-5919:
---------------------------------------
ppatierno opened a new pull request #5126: KAFKA-5919: Adding checks on
"version" field for tools using it
URL: https://github.com/apache/kafka/pull/5126
Adding checks on "version" field for tools using it.
This is a new version of the closed PR #3887 (to see for more comments and
related discussion).
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Adding checks on "version" field for tools using it
> ---------------------------------------------------
>
> Key: KAFKA-5919
> URL: https://issues.apache.org/jira/browse/KAFKA-5919
> Project: Kafka
> Issue Type: Bug
> Components: tools
> Reporter: Paolo Patierno
> Assignee: Paolo Patierno
> Priority: Minor
> Fix For: 2.0.0
>
>
> Hi,
> the kafka-delete-records script allows user to pass information about records
> to delete through a JSON file. Such file, as described in the command help,
> is made by a "partitions" array and a "version" field. Reading
> [KIP-107|https://cwiki.apache.org/confluence/display/KAFKA/KIP-107%3A+Add+purgeDataBefore%28%29+API+in+AdminClient]
> and the DeleteRecords API (Key: 21) description it's not clear what such
> field is and even it's not used at all (in the current implementation).
> It turned out that the field is for having backward compatibility in the
> future where the JSON format could change. This JIRA is about adding more
> checks on the "version" field having it not mandatory but assuming the
> earliest version (current 1) if it's omitted from the JSON file.
> The same for the kafka-reassign-partitions which has a topics-to-move JSON
> file as input (used with --generate option) and the partitions-to-move.json
> (used with --execute option). In both cases the same logic can be applied as
> above.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
