satishd commented on code in PR #14352:
URL: https://github.com/apache/kafka/pull/14352#discussion_r1318539662
##########
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageManager.java:
##########
@@ -121,14 +121,17 @@ InputStream fetchLogSegment(RemoteLogSegmentMetadata
remoteLogSegmentMetadata,
/**
* Returns the index for the respective log segment of {@link
RemoteLogSegmentMetadata}.
+ * <p>
+ * Note: The transaction index may not exist because segments created
prior to version 2.8.0 or non-transactional topics...etc.
+ * In this case, it should still return an InputStream with empty content,
instead of returning {@code null}.
Review Comment:
Right, transaction index can be null, but there is an existing
https://issues.apache.org/jira/browse/KAFKA-14993 to address that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
