jsancio commented on code in PR #12763: URL: https://github.com/apache/kafka/pull/12763#discussion_r1319003199
########## raft/src/main/java/org/apache/kafka/raft/FileBasedStateStore.java: ########## @@ -149,6 +149,7 @@ private void writeElectionStateToFile(final File stateFile, QuorumStateData stat writer.write(jsonState.toString()); writer.flush(); fileOutputStream.getFD().sync(); + fileOutputStream.close(); Review Comment: I created this PR which includes this suggestion: https://github.com/apache/kafka/pull/14354 cc @dengziming @showuon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org