hudeqi commented on PR #14243: URL: https://github.com/apache/kafka/pull/14243#issuecomment-1711358661
> I am yet to look into the part about why we need `@volatile var remoteLogManagerOpt` and why we need to modify tests but leaving some intermediate comments meanwhile. Thanks for your review, @divijvaidya . Adding the volatile flag to `remoteLogManagerOpt` is just consistent with the `_logManager` next to it to increase readability. In fact, I think the volatile flags of these two variables can be removed. Please reconfirm this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
