Cerchie commented on PR #14360: URL: https://github.com/apache/kafka/pull/14360#issuecomment-1716362225
> > There might be some discussion to be had regarding what to say about why these are deprecated. > > Not sure if we need to put this into the docs? If we want to say something about it, we could add a link to the corresponding KIP, ie, "Deprecated via KIP-xxx" -- the KIP will contain the necessary information. > > What we should do in any case is, link to configs that should be used instead of the deprecated ones (seems we cannot do this in this PR though, as some new config are still missing in the doc -- or we add them in this PR directly) > > > Also, in the [StreamsConfig.java line 1355](https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java#L1355), some logic throws errors when EXACTLY_ONCE, EXACTLY_ONCE_BETA, and RETRIES are used. Should that be updated as well, considering that there are new pieces of config with the @deprecated annotation? > > Yes, very good idea to extend this code and also log an error if other deprecated configs are used. happy to add those new config in this PR -- shall I also add that `StreamsConfig.java` logic update in this PR, or separate it out since it's a code update rather than a docs one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
