kirktrue commented on code in PR #14359:
URL: https://github.com/apache/kafka/pull/14359#discussion_r1323614034
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##########
@@ -67,35 +54,34 @@ public abstract class AbstractFetch<K, V> implements
Closeable {
private final Logger log;
protected final LogContext logContext;
- protected final ConsumerNetworkClient client;
+ protected final NodeStatusDetector nodeStatusDetector;
protected final ConsumerMetadata metadata;
protected final SubscriptionState subscriptions;
protected final FetchConfig<K, V> fetchConfig;
protected final Time time;
protected final FetchMetricsManager metricsManager;
+ protected final FetchBuffer fetchBuffer;
+ protected final BufferSupplier decompressionBufferSupplier;
+ protected final Set<Integer> nodesWithPendingFetchRequests;
+ protected final IdempotentCloser idempotentCloser = new IdempotentCloser();
- private final BufferSupplier decompressionBufferSupplier;
- private final ConcurrentLinkedQueue<CompletedFetch<K, V>> completedFetches;
private final Map<Integer, FetchSessionHandler> sessionHandlers;
- private final Set<Integer> nodesWithPendingFetchRequests;
-
- private CompletedFetch<K, V> nextInLineFetch;
public AbstractFetch(final LogContext logContext,
- final ConsumerNetworkClient client,
+ NodeStatusDetector nodeStatusDetector,
Review Comment:
Yes. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
