showuon commented on code in PR #14379: URL: https://github.com/apache/kafka/pull/14379#discussion_r1323876232
########## storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataManager.java: ########## @@ -36,18 +36,17 @@ * remote.log.metadata.manager.class.name is not configured. * </p> * <p> - * <code>remote.log.metadata.manager.class.path</code> property is about the class path of the RemoteLogStorageManager - * implementation. If specified, the RemoteLogStorageManager implementation and its dependent libraries will be loaded + * <code>remote.log.metadata.manager.class.path</code> property is about the class path of the RemoteLogMetadataManager + * implementation. If specified, the RemoteLogMetadataManager implementation and its dependent libraries will be loaded * by a dedicated classloader which searches this class path before the Kafka broker class path. The syntax of this * parameter is same with the standard Java class path string. * </p> * <p> * <code>remote.log.metadata.manager.listener.name</code> property is about listener name of the local broker to which - * it should get connected if needed by RemoteLogMetadataManager implementation. When this is configured all other - * required properties can be passed as properties with prefix of 'remote.log.metadata.manager.listener. + * it should get connected if needed by RemoteLogMetadataManager implementation. Review Comment: We won't pass prefix of `remote.log.metadata.manager.listener`. Remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
