OmniaGM commented on PR #13201: URL: https://github.com/apache/kafka/pull/13201#issuecomment-1717877198
> Hi @OmniaGM, thanks. I left some comments. > > Additionally, this error message is different from previous implementation: > > ```shell > ### OLD > $ bin/kafka-topics.sh --bootstrap-server :9092 --describe --topic my-topic-foo --delete-config sdsad > Option "[delete-config]" can't be used with option "[describe]" > > ### NEW > $ bin/kafka-topics.sh --bootstrap-server :9092 --describe --topic my-topic-foo --delete-config sdsad > Option "[delete-config]" can't be used with option "[bootstrap-server]" > ``` Good catch @fvaleri , I missed that `immutable.Set` which is used to define invalid options in old scala code does preserve the order of insertion so when we check `bootstrap` option isn't the first on the list to compare but instead it's `describe`. I updated the code to use `LinkedHashSet` instead of `Set` in Java. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
