philipnee commented on code in PR #14386:
URL: https://github.com/apache/kafka/pull/14386#discussion_r1325349677
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CommitApplicationEvent.java:
##########
@@ -19,22 +19,23 @@
import org.apache.kafka.clients.consumer.OffsetAndMetadata;
import org.apache.kafka.common.TopicPartition;
+import java.util.Collections;
import java.util.Map;
import java.util.Optional;
import java.util.concurrent.CompletableFuture;
-public class CommitApplicationEvent extends ApplicationEvent {
- final private CompletableFuture<Void> future;
+public class CommitApplicationEvent extends CompletableApplicationEvent<Void> {
final private Map<TopicPartition, OffsetAndMetadata> offsets;
public CommitApplicationEvent(final Map<TopicPartition, OffsetAndMetadata>
offsets) {
super(Type.COMMIT);
- this.offsets = offsets;
- Optional<Exception> exception = isValid(offsets);
- if (exception.isPresent()) {
- throw new RuntimeException(exception.get());
+ this.offsets = Collections.unmodifiableMap(offsets);
+
+ for (OffsetAndMetadata offsetAndMetadata : offsets.values()) {
Review Comment:
There are quite a few events out there that need to be refactored if we do
it this way. Would it be ok for you to skip this for now and I will post a
MINOR patch to address after this is closed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
