lianetm commented on code in PR #14385:
URL: https://github.com/apache/kafka/pull/14385#discussion_r1327788743
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##########
@@ -667,6 +683,35 @@ private static <K, V> ClusterResourceListeners
configureClusterResourceListeners
return clusterResourceListeners;
}
+ /**
+ *
+ * Indicates if the consumer is using the Kafka-based offset management
strategy,
+ * according to config {@link CommonClientConfigs#GROUP_ID_CONFIG}
+ */
+ private boolean isCommittedOffsetsManagementEnabled() {
+ return groupId.isPresent();
+ }
+
+ /**
+ * Refresh the committed offsets for provided partitions.
+ *
+ * @param timer Timer bounding how long this method can block
+ * @return true iff the operation completed within the timeout
+ */
+ private boolean refreshCommittedOffsetsIfNeeded(Timer timer) {
Review Comment:
the `timer` param is included in the java doc, do you mean something else
maybe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
