philipnee commented on code in PR #14391:
URL: https://github.com/apache/kafka/pull/14391#discussion_r1328230578
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEvent.java:
##########
@@ -21,18 +21,27 @@
*/
abstract public class ApplicationEvent {
public final Type type;
+ protected final String owner;
- protected ApplicationEvent(Type type) {
+ protected ApplicationEvent(Type type, String owner) {
Review Comment:
maybe we could get rid of owner after all, and just have the calling class
to print its name so that we could follow a more conventional toString().
Here's an example of how it might look like after getting rid of owner. Would
this work?
```
ListOffsetsApplicationEvent{type=LIST_OFFSETS,
future=java.util.concurrent.CompletableFuture@bdd2027[Not completed],
timestampsToSearch={}, requireTimestamps=false}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
