yashmayya commented on code in PR #14371:
URL: https://github.com/apache/kafka/pull/14371#discussion_r1330362866
##########
connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectClusterAssertions.java:
##########
@@ -455,48 +455,42 @@ public void
assertConnectorIsFailedAndTasksHaveFailed(String connectorName, int
}
/**
- * Assert that a connector and its tasks are not running.
+ * Assert that a connector does not exist. This can be used to verify that
a connector has been successfully deleted.
*
* @param connectorName the connector name
* @param detailMessage the assertion message
* @throws InterruptedException
*/
- public void assertConnectorAndTasksAreNotRunning(String connectorName,
String detailMessage)
+ public void assertConnectorDoesNotExist(String connectorName, String
detailMessage)
Review Comment:
I preferred `assertConnectorDoesNotExist` over `assertConnectorDeleted`
since it's a more accurate description of what exactly is being verified.
> As such, the connector won't exist only when it's deleted
It could also never have been created in the first place right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
