nizhikov commented on code in PR #13929:
URL: https://github.com/apache/kafka/pull/13929#discussion_r1331235825
##########
core/src/main/scala/kafka/server/AbstractFetcherManager.scala:
##########
@@ -31,6 +32,9 @@ abstract class AbstractFetcherManager[T <:
AbstractFetcherThread](val name: Stri
extends Logging {
private val metricsGroup = new KafkaMetricsGroup(this.getClass)
+ // Visible for test
+ private[server] var metricNamesToTags: Map[String, java.util.Map[String,
String]] = Map.empty
Review Comment:
Can we use mutable map like it's done for `fetcherThreadMap`?
Or even `Set<MetricName>`, see comment below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
