kirktrue commented on code in PR #14357: URL: https://github.com/apache/kafka/pull/14357#discussion_r1333659148
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableBackgroundEvent.java: ########## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.clients.consumer.internals.events; + +import org.apache.kafka.clients.consumer.internals.ConsumerUtils; +import org.apache.kafka.common.utils.Timer; + +import java.util.concurrent.CompletableFuture; + +/** + * Background thread event with a result in the form of a future, that can be retrieved within a + * timeout based on completion. + * + * @param <T> + */ +public abstract class CompletableBackgroundEvent<T> extends BackgroundEvent { + + private final CompletableFuture<T> future; + + protected CompletableBackgroundEvent(Type type) { + super(type); + this.future = new CompletableFuture<>(); + } + + public CompletableFuture<T> future() { + return future; + } + + public T get(Timer timer) { + return ConsumerUtils.getResult(future, timer); + } + + public void chain(final CompletableFuture<T> providedFuture) { + providedFuture.whenComplete((value, exception) -> { + if (exception != null) { + this.future.completeExceptionally(exception); + } else { + this.future.complete(value); + } + }); + } + + @Override + public boolean equals(Object o) { + if (this == o) return true; + if (o == null || getClass() != o.getClass()) return false; + if (!super.equals(o)) return false; + + CompletableBackgroundEvent<?> that = (CompletableBackgroundEvent<?>) o; + + return future.equals(that.future); + } + + @Override + public int hashCode() { + int result = super.hashCode(); + result = 31 * result + future.hashCode(); + return result; + } + + @Override + protected String toStringBase() { + return super.toStringBase() + ", future=" + future; + } + + @Override + public String toString() { + return getClass().getSimpleName() + "{" + Review Comment: Unfortunately it seems pretty inconsistent. `MetadataCache`, as the first example I could find, uses the more "standard" Java brackets 🤷♂️ ########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableBackgroundEvent.java: ########## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.clients.consumer.internals.events; + +import org.apache.kafka.clients.consumer.internals.ConsumerUtils; +import org.apache.kafka.common.utils.Timer; + +import java.util.concurrent.CompletableFuture; + +/** + * Background thread event with a result in the form of a future, that can be retrieved within a + * timeout based on completion. + * + * @param <T> + */ +public abstract class CompletableBackgroundEvent<T> extends BackgroundEvent { + + private final CompletableFuture<T> future; + + protected CompletableBackgroundEvent(Type type) { + super(type); + this.future = new CompletableFuture<>(); + } + + public CompletableFuture<T> future() { + return future; + } + + public T get(Timer timer) { + return ConsumerUtils.getResult(future, timer); + } + + public void chain(final CompletableFuture<T> providedFuture) { + providedFuture.whenComplete((value, exception) -> { + if (exception != null) { + this.future.completeExceptionally(exception); + } else { + this.future.complete(value); + } + }); + } + + @Override + public boolean equals(Object o) { + if (this == o) return true; + if (o == null || getClass() != o.getClass()) return false; + if (!super.equals(o)) return false; + + CompletableBackgroundEvent<?> that = (CompletableBackgroundEvent<?>) o; + + return future.equals(that.future); + } + + @Override + public int hashCode() { + int result = super.hashCode(); + result = 31 * result + future.hashCode(); + return result; + } + + @Override + protected String toStringBase() { + return super.toStringBase() + ", future=" + future; + } + + @Override + public String toString() { + return getClass().getSimpleName() + "{" + Review Comment: Unfortunately it seems pretty inconsistent. `MetadataCache`, as the first example I could find, uses the more "standard" Java brackets 🤷♂️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
