CalvinConfluent commented on code in PR #14417: URL: https://github.com/apache/kafka/pull/14417#discussion_r1333694211
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/CoordinatorRuntimeMetrics.java: ########## @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.group.metrics; + +import com.yammer.metrics.core.Gauge; +import com.yammer.metrics.core.MetricName; +import com.yammer.metrics.core.MetricsRegistry; +import org.apache.kafka.common.metrics.Metrics; +import org.apache.kafka.common.metrics.Sensor; +import org.apache.kafka.common.metrics.stats.Avg; +import org.apache.kafka.common.metrics.stats.Max; +import org.apache.kafka.server.metrics.KafkaYammerMetrics; + +import java.util.Arrays; +import java.util.concurrent.atomic.AtomicLong; + +/** + * Used by the group and transaction coordinator runtimes, the metrics suite holds partition state gauges and sensors. + */ +public abstract class CoordinatorRuntimeMetrics implements AutoCloseable { + /** + * Metric to count the number of partitions in Initial state. + */ + protected final MetricName numPartitionsInitial = getMetricName("NumPartitionsInitial"); + /** + * Visible for testing. + */ + public static final AtomicLong NUM_PARTITIONS_INITIAL = new AtomicLong(0); + + /** + * Metric to count the number of partitions in Loading state. + */ + protected final MetricName numPartitionsLoading = getMetricName("NumPartitionsLoading"); + /** + * Visible for testing. + */ + public static final AtomicLong NUM_PARTITIONS_LOADING = new AtomicLong(0); + + /** + * Metric to count the number of partitions in Active state. + */ + protected final MetricName numPartitionsActive = getMetricName("NumPartitionsActive"); + /** + * Visible for testing. + */ + public static final AtomicLong NUM_PARTITIONS_ACTIVE = new AtomicLong(0); + + /** + * Metric to count the number of partitions in Closed state. + */ + protected final MetricName numPartitionsClosed = getMetricName("NumPartitionsClosed"); + /** + * Visible for testing. + */ + public static final AtomicLong NUM_PARTITIONS_CLOSED = new AtomicLong(0); + + /** + * Metric to count the number of partitions in Failed state. + */ + protected final MetricName numPartitionsFailed = getMetricName("NumPartitionsFailed"); + /** + * Visible for testing. + */ + public static final AtomicLong NUM_PARTITIONS_FAILED = new AtomicLong(0); + + protected MetricsRegistry registry; + protected Metrics metrics; + public Sensor partitionLoadSensor; + + /** + * Add metrics to the registries. + */ + protected void initializeMetrics() { + registry.newGauge(numPartitionsInitial, new Gauge<Long>() { + @Override + public Long value() { + return NUM_PARTITIONS_INITIAL.get(); + } + }); + + registry.newGauge(numPartitionsLoading, new Gauge<Long>() { + @Override + public Long value() { + return NUM_PARTITIONS_LOADING.get(); + } + }); + + registry.newGauge(numPartitionsActive, new Gauge<Long>() { + @Override + public Long value() { + return NUM_PARTITIONS_ACTIVE.get(); + } + }); + + registry.newGauge(numPartitionsClosed, new Gauge<Long>() { + @Override + public Long value() { + return NUM_PARTITIONS_CLOSED.get(); + } + }); + + registry.newGauge(numPartitionsFailed, new Gauge<Long>() { + @Override + public Long value() { + return NUM_PARTITIONS_FAILED.get(); + } + }); + + this.partitionLoadSensor.add( + metrics.metricName( + "partition-load-time-max", + metricsGroup(), + "The max time it took to load the partitions in the last 30sec" Review Comment: Just curious about this, where do we set the 30s? Or it is just the default value? ########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ########## @@ -1242,7 +1304,11 @@ public void scheduleLoadOperation( case FAILED: case INITIAL: context.transitionTo(CoordinatorState.LOADING); - loader.load(tp, context.coordinator).whenComplete((state, exception) -> { + loader.load(tp, context.coordinator).whenComplete((summary, exception) -> { + if (summary != null) { + log.debug("Finished loading tp={}, LoadSummary={}", tp, summary); Review Comment: I am a bit confused here. The log says "Finished loading", but we also schedule an internal operation which is commented as "CompleteLoad" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
