lucasbru commented on code in PR #14437:
URL: https://github.com/apache/kafka/pull/14437#discussion_r1335540581


##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##########
@@ -1043,6 +1046,28 @@ public void shouldResumeActiveStatefulTask() throws 
Exception {
         verify(changelogReader, times(2)).enforceRestoreActive();
     }
 
+    @Test
+    public void shouldAwaitWhenAllTasksPaused() throws Exception {

Review Comment:
   This tests the absence of "restore" calls when all tasks are paused. This 
requires "smelly" constructs like `Mockito.reset` and `Thread.sleep`. We could 
alternatively not test this - the absence of something in a certain timeframe 
is not very amenable to unit testing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to