Hangleton commented on code in PR #14459:
URL: https://github.com/apache/kafka/pull/14459#discussion_r1338522387
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##########
@@ -310,7 +310,7 @@ private <T> T loadIndexFile(File file,
RemoteLogSegmentMetadata remoteLogSegment
if (Files.exists(indexFile.toPath())) {
try {
index = readIndex.apply(indexFile);
- } catch (CorruptRecordException ex) {
Review Comment:
Thanks, I wanted to confirm that it is indeed the case although we are
dealing with indexes here. The rationale being that `CorruptRecordException`
may have been introduced purposefully to cover a use case. Was this not covered
by a test in an initial PR, and if it was, did the test make an incorrect
assumption, or exercised an invalid scenario?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
