showuon commented on code in PR #14453:
URL: https://github.com/apache/kafka/pull/14453#discussion_r1340969804
##########
core/src/test/scala/unit/kafka/tools/DumpLogSegmentsTest.scala:
##########
@@ -236,7 +236,7 @@ class DumpLogSegmentsTest {
def testDumpMetadataRecords(): Unit = {
val mockTime = new MockTime
val logConfig = LogTestUtils.createLogConfig(segmentBytes = 1024 * 1024)
- val log = LogTestUtils.createLog(logDir, logConfig, new BrokerTopicStats,
mockTime.scheduler, mockTime)
+ log = LogTestUtils.createLog(logDir, logConfig, new BrokerTopicStats,
mockTime.scheduler, mockTime)
Review Comment:
Nice catch!
##########
core/src/test/scala/unit/kafka/log/LogLoaderTest.scala:
##########
@@ -58,6 +58,7 @@ class LogLoaderTest {
val producerIdExpirationCheckIntervalMs: Int =
kafka.server.Defaults.ProducerIdExpirationCheckIntervalMs
val tmpDir = TestUtils.tempDir()
val logDir = TestUtils.randomPartitionLogDir(tmpDir)
+ var logsToClose: Seq[UnifiedLog] = Seq()
Review Comment:
nit: We can use `ListBuffer` and `ListBuffer#addOne` method for mutable list
instance. `Seq` is used for immutable instance. Ref:
https://stackoverflow.com/a/42761998 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
