chb2ab commented on code in PR #14444: URL: https://github.com/apache/kafka/pull/14444#discussion_r1342850556
########## core/src/main/scala/kafka/server/KafkaApis.scala: ########## @@ -559,6 +560,30 @@ class KafkaApis(val requestChannel: RequestChannel, } } + case class LeaderNode(leaderId: Int, leaderEpoch: Int, node: Node) + + private def getCurrentLeader(tp: TopicPartition): LeaderNode = { + val partitionInfoOrError = replicaManager.getPartitionOrError(tp) + var leaderId = -1 + var leaderEpoch = -1 + partitionInfoOrError match { + case Right(x) => + leaderId = x.leaderReplicaIdOpt.getOrElse(-1) + leaderEpoch = x.getLeaderEpoch + case Left(x) => + debug(s"Unable to retrieve local leaderId and Epoch with error $x, falling back to metadata cache") + val partitionInfo = metadataCache.getPartitionInfo(tp.topic, tp.partition) + partitionInfo.foreach { info => Review Comment: Looking at other uses of partitionInfo I think this is a style choice. There can only be 1 partitionInfo in the getPartitionInfo object, so the forEach should only ever access 1 entry, I think this is just a more succinct way of accessing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org