jolshan commented on code in PR #14470:
URL: https://github.com/apache/kafka/pull/14470#discussion_r1342933163
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -892,16 +889,11 @@ class UnifiedLog(@volatile var logStartOffset: Long,
maybeDuplicate match {
case Some(duplicate) =>
- appendInfo.setFirstOffset(Optional.of(new
LogOffsetMetadata(duplicate.firstOffset)))
+ appendInfo.setFirstOffset(duplicate.firstOffset)
appendInfo.setLastOffset(duplicate.lastOffset)
appendInfo.setLogAppendTime(duplicate.timestamp)
appendInfo.setLogStartOffset(logStartOffset)
case None =>
- // Before appending update the first offset metadata to include
segment information
- appendInfo.setFirstOffset(appendInfo.firstOffset.map {
offsetMetadata =>
Review Comment:
We removed this since the default is zero, and in that case we take the
segment base offset anyway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
