kirktrue commented on PR #14463: URL: https://github.com/apache/kafka/pull/14463#issuecomment-1745740348
> Thanks for this PR @kirktrue ! I can see easily see how this can be extended for static membership case. I had just one question(LGTM o/w) => > > 1. Do [these](https://github.com/apache/kafka/blob/trunk/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java#L1368-L1370) lines also qualify for having -1 replaced with `LEAVE_GROUP_EPOCH`? In this case, it appears to be a member leave group situation. I've updated the code to use the constant in place of `-1`. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
